-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change all ZAP XML basic data types to lowercase
#29706
Merged
mergify
merged 9 commits into
project-chip:master
from
andy31415:lowercase_standard_types
Oct 12, 2023
Merged
Change all ZAP XML basic data types to lowercase
#29706
mergify
merged 9 commits into
project-chip:master
from
andy31415:lowercase_standard_types
Oct 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs and
jmeg-sfy
October 11, 2023 15:05
pullapprove
bot
requested review from
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
October 11, 2023 15:05
PR #29706: Size comparison from e8f516a to b14be07 Full report (4 builds for cc32xx, mbed, qpg)
|
andy31415
added
the
skip-protocol-compatibility
Marker that protocol backwards compatibility checks are to be skipped
label
Oct 11, 2023
Skip protocol compatibility: I am not actually changing types |
PR #29706: Size comparison from 78eb271 to 83a8164 Decreases (1 build for bl702)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tcarmelveilleux
approved these changes
Oct 11, 2023
bzbarsky-apple
approved these changes
Oct 11, 2023
PR #29706: Size comparison from 94f3049 to fa3b0ea Full report (38 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #29706: Size comparison from fd925e4 to f040b01 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #29706: Size comparison from fd925e4 to 2f7205f Increases above 0.2%:
Increases (47 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, telink)
Decreases (12 builds for linux, psoc6)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #29706: Size comparison from fd925e4 to 3ad5017 Increases above 0.2%:
Increases (50 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, telink)
Decreases (13 builds for bl702, linux, psoc6)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Replace bitmaps and enums * Replace all the rest * Zap regen * Replace Percent with percent in yaml tests * Regenerate zap * More type updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app
controller
examples
review - approved
skip-protocol-compatibility
Marker that protocol backwards compatibility checks are to be skipped
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes all of enum8, bitmap8, int*, and so on to be lowercase. I basically ran this:
Also fixed yaml tests specifically for percentage type checks: